-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop examples from main repository #2843
Comments
I've pushed this off for quite a while, so apologies if this delays 1.5.0. We need to decide what will constitute completion of this issue. The examples are used for CI, documentation and are intended to be runnable by users.
Inputs on 1 & 2 would be very much appreciated. |
My 2ct
Running the full workflows on each commit is not giving us great coverage or helping us catch many bugs. First, because the examples only exercise a small set of all the available interfaces. Second, because we check on something we don't care much about (i.e., the particular examples we are testing are chosen for the intuition that will cover a good bunch of nipype code, but nothing more elaborate). For a while I've been trying to think of some "test" plugin or modification of plugin for nipype that "fakes" any command line call (i.e., checks all inputs exist and creates empty files for every output). But for that, we would need to nail the automated prediction of outputs (along the lines of #3150), and very likely many other things.
intersphinx just resolves object references, but will not render autodoc documentation or anything outside the project. At this moment, examples are built separately in a step before sphinx-build is called. We can keep doing that but fetching the examples from niflows anyways.
+1 |
I'm good with moving examples to a separate site and linking. In the short term, since it sounds easy, I'll plan on continuing to build into the nipype docs, but I've opened niflows/nipype1-examples#3. |
i'm fine with moving examples. |
Summary
I've moved the
examples/
directory into niflows/nipype1-examples, and set up CircleCI testing on these.As we further develop niflows infrastructure, we should make sure that a release branch (or pre-release on PyPI) triggers tests with the new nipype on all niflows. Once that is working, we can remove the
examples/
directory and drop the extended tests from nipype.The text was updated successfully, but these errors were encountered: