Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove examples from repository #3172

Merged
merged 7 commits into from
Feb 22, 2020
Merged

Conversation

effigies
Copy link
Member

Summary

Closes #2843.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #3172 into master will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3172      +/-   ##
==========================================
+ Coverage   64.00%   64.86%   +0.85%     
==========================================
  Files         299      299              
  Lines       39493    39493              
  Branches     5219     5219              
==========================================
+ Hits        25279    25618     +339     
+ Misses      13171    12826     -345     
- Partials     1043     1049       +6     
Flag Coverage Δ
#unittests 64.86% <ø> (+0.82%) ⬆️
Impacted Files Coverage Δ
nipype/__init__.py 34.37% <0.00%> (ø) ⬆️
nipype/testing/__init__.py 88.88% <0.00%> (ø) ⬆️
nipype/utils/filemanip.py 74.05% <0.00%> (+0.47%) ⬆️
nipype/interfaces/spm/preprocess.py 52.78% <0.00%> (+0.65%) ⬆️
nipype/pipeline/engine/utils.py 71.15% <0.00%> (+0.91%) ⬆️
nipype/interfaces/dcm2nii.py 49.76% <0.00%> (+0.93%) ⬆️
nipype/interfaces/freesurfer/model.py 64.19% <0.00%> (+1.12%) ⬆️
nipype/pipeline/engine/nodes.py 78.15% <0.00%> (+1.29%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 65.94% <0.00%> (+1.47%) ⬆️
nipype/pipeline/plugins/base.py 58.90% <0.00%> (+1.64%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77a5bd...22cbbb8. Read the comment docs.

@effigies effigies marked this pull request as ready for review February 21, 2020 18:12
@effigies effigies added this to the 1.5.0 milestone Feb 22, 2020
@effigies
Copy link
Member Author

This is ready for review.

@satra
Copy link
Member

satra commented Feb 22, 2020

LGTM. I am happy to see things being stripped away to better places :)

@effigies effigies merged commit d610478 into nipy:master Feb 22, 2020
@effigies effigies deleted the enh/move_examples branch February 22, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop examples from main repository
2 participants