Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Python 3.4 is not compatible with the recent release of lxml-4.4.0 #2980

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Jul 31, 2019

We are starting to see failed jobs in Travis.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@oesteban oesteban requested a review from effigies July 31, 2019 19:23
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes, cool.

We should also probably drop 3.4 support soon, anyway.

@effigies
Copy link
Member

The cancelled test was me, because we don't need to double-up our Travis builds when the queue is slammed.

@oesteban
Copy link
Contributor Author

It's not passing. Is there a way to create requirements.txt filtering versions?

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2980 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
+ Coverage   67.08%   67.61%   +0.53%     
==========================================
  Files         343      344       +1     
  Lines       43767    43785      +18     
  Branches     5466     5469       +3     
==========================================
+ Hits        29361    29607     +246     
+ Misses      13687    13467     -220     
+ Partials      719      711       -8
Flag Coverage Δ
#smoketests 50.39% <ø> (ø) ⬆️
#unittests 65.04% <ø> (+0.79%) ⬆️
Impacted Files Coverage Δ
nipype/info.py 94.11% <ø> (ø) ⬆️
nipype/testing/__init__.py 88.88% <0%> (ø)
nipype/interfaces/spm/preprocess.py 57.03% <0%> (+0.32%) ⬆️
nipype/utils/filemanip.py 80.08% <0%> (+0.4%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (+0.98%) ⬆️
nipype/interfaces/freesurfer/model.py 64.25% <0%> (+1.12%) ⬆️
nipype/interfaces/io.py 54.94% <0%> (+1.88%) ⬆️
nipype/interfaces/spm/base.py 87.08% <0%> (+1.98%) ⬆️
nipype/interfaces/freesurfer/utils.py 62.94% <0%> (+2.13%) ⬆️
nipype/workflows/smri/freesurfer/autorecon1.py 46.75% <0%> (+5.09%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2f94f...39522fc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2980 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
+ Coverage   67.08%   67.61%   +0.53%     
==========================================
  Files         343      344       +1     
  Lines       43767    43785      +18     
  Branches     5466     5469       +3     
==========================================
+ Hits        29361    29607     +246     
+ Misses      13687    13467     -220     
+ Partials      719      711       -8
Flag Coverage Δ
#smoketests 50.39% <ø> (ø) ⬆️
#unittests 65.04% <ø> (+0.79%) ⬆️
Impacted Files Coverage Δ
nipype/info.py 94.11% <ø> (ø) ⬆️
nipype/testing/__init__.py 88.88% <0%> (ø)
nipype/interfaces/spm/preprocess.py 57.03% <0%> (+0.32%) ⬆️
nipype/utils/filemanip.py 80.08% <0%> (+0.4%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (+0.98%) ⬆️
nipype/interfaces/freesurfer/model.py 64.25% <0%> (+1.12%) ⬆️
nipype/interfaces/io.py 54.94% <0%> (+1.88%) ⬆️
nipype/interfaces/spm/base.py 87.08% <0%> (+1.98%) ⬆️
nipype/interfaces/freesurfer/utils.py 62.94% <0%> (+2.13%) ⬆️
nipype/workflows/smri/freesurfer/autorecon1.py 46.75% <0%> (+5.09%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2f94f...39522fc. Read the comment docs.

@oesteban
Copy link
Contributor Author

oesteban commented Aug 1, 2019

Travis worked on my branch. Merging in.

@oesteban oesteban merged commit 81231c8 into master Aug 1, 2019
@oesteban oesteban deleted the fix/deps-lxml-py34 branch August 1, 2019 05:22
@effigies effigies added this to the 1.2.1 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants