-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Python 3.4 is not compatible with the recent release of lxml-4.4.0 #2980
Conversation
We are starting to see failed jobs in Travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it passes, cool.
We should also probably drop 3.4 support soon, anyway.
The cancelled test was me, because we don't need to double-up our Travis builds when the queue is slammed. |
It's not passing. Is there a way to create |
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
+ Coverage 67.08% 67.61% +0.53%
==========================================
Files 343 344 +1
Lines 43767 43785 +18
Branches 5466 5469 +3
==========================================
+ Hits 29361 29607 +246
+ Misses 13687 13467 -220
+ Partials 719 711 -8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
+ Coverage 67.08% 67.61% +0.53%
==========================================
Files 343 344 +1
Lines 43767 43785 +18
Branches 5466 5469 +3
==========================================
+ Hits 29361 29607 +246
+ Misses 13687 13467 -220
+ Partials 719 711 -8
Continue to review full report at Codecov.
|
Travis worked on my branch. Merging in. |
We are starting to see failed jobs in Travis.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment