Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guideline link was outdated #188

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

Sayamame-beans
Copy link

What

NSFWガイドラインのリンクを更新

Why

#144 (comment)

Additional info (optional)

コンパネから設定可能にするべきやつではあります
changelogは不要と判断

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Collaborator

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずとしてはよしなんだけど、ハードコード続けるならリダイレクト挟めるようになっててほしいきもする

@Sayamame-beans
Copy link
Author

ハードコードはやめたい
でもリダイレクト等が出来るならその方が良さそうではありますね(常に同じURLで最新の規約/ガイドラインにアクセス出来るようになるので)

@niwaniwa
Copy link
Collaborator

niwaniwa commented May 7, 2024

リダイレクトについては私の方で対応しますね
URLどうしよう

@Sayamame-beans
Copy link
Author

mi.niri.la/misskey-tos , misskey-guideline
とか
niri.la/misskey/tos , guideline
とか…?

@niwaniwa
Copy link
Collaborator

niwaniwa commented May 9, 2024

mi.niri.la/misskey-tos , misskey-guideline
良さそう

@Sayamame-beans
Copy link
Author

@niwaniwa 進捗どうですか?

@niwaniwa
Copy link
Collaborator

しんちょくだめです
土日に対応します!

@Sayamame-beans Sayamame-beans merged commit 0cefba1 into develop May 15, 2024
13 checks passed
@Sayamame-beans Sayamame-beans deleted the fix-guideline-link branch May 15, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants