Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable resize scale #193

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Selectable resize scale #193

merged 3 commits into from
Jun 3, 2024

Conversation

Sayamame-beans
Copy link

What

縮小時の解像度を2048, 2560, 4096, 8192から選択可能にします。

縮小した方がファイルサイズが大きくなってしまう場合は縮小していない画像を利用する、というMisskeyの仕様があるため、この解像度設定よりも大きなままで保存されることもあります。

という旨をimageResizeDescriptionに加えるか迷っています。

Why

fix: #182

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

locales/ja-JP.yml Outdated Show resolved Hide resolved
packages/frontend/src/scripts/upload/compress-config.ts Outdated Show resolved Hide resolved
@Sayamame-beans
Copy link
Author

ここまでくるとWebPublicの画質もSelectableにすれば良いんじゃないかという気持ちになってきました。

Copy link
Collaborator

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKかな

@anatawa12 anatawa12 merged commit 3a03183 into develop Jun 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

画像の縮小先解像度を選択可能にする
2 participants