Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ユーザーのアイコン/バナーの変更可否をロールで設定可能に #207

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

Sayamame-beans
Copy link

Cherry-picked from misskey-dev#14078

What

Why

Additional info (optional)

動作確認に若干の不安

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

github-actions bot commented Jul 3, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -79474,6 +79474,9 @@
           "alwaysMarkNsfw": {
             "type": "boolean"
           },
+          "canUpdateBioMedia": {
+            "type": "boolean"
+          },
           "pinLimit": {
             "type": "integer"
           },
@@ -79522,6 +79525,7 @@
           "canHideAds",
           "driveCapacityMb",
           "alwaysMarkNsfw",
+          "canUpdateBioMedia",
           "pinLimit",
           "antennaLimit",
           "wordMuteLimit",

Get diff files from Workflow Page

@Sayamame-beans
Copy link
Author

Sayamame-beans commented Jul 3, 2024

🤔

@Sayamame-beans
Copy link
Author

e2eテストが落ちている

Copy link
Collaborator

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード見て気になったのはこのくらい

Co-authored-by: anatawa12 <anatawa12@icloud.com>
@Sayamame-beans
Copy link
Author

e2eテストが落ちている

misskey-dev#14111 かも

@anatawa12
Copy link
Collaborator

見えない落ち方は面倒なので 14111 をpickしてそれ先mergeにしたいかも

@Sayamame-beans
Copy link
Author

ok

@Sayamame-beans
Copy link
Author

#208

@anatawa12
Copy link
Collaborator

とおったのでよし〜

@anatawa12 anatawa12 merged commit 65f0d53 into develop Jul 3, 2024
27 checks passed
@Sayamame-beans Sayamame-beans deleted the pick-14078 branch July 3, 2024 14:41
@Sayamame-beans Sayamame-beans mentioned this pull request Jul 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants