Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers for RN@0.40.0 #487

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

sntran
Copy link
Contributor

@sntran sntran commented Jan 7, 2017

React Native has made a breaking change to header paths in 0.40.0.

Besides fixing the headers, this adds RN@0.40 and React@15.4.0 as
peer dependencies and bump version.

This PR simply adjusts the headers.

React Native has made a breaking change to header paths in [0.40.0](https://github.com/facebook/react-native/releases/tag/v0.40.0).

Besides fixing the headers, this adds `RN@0.40` and `React@15.4.0` as
peer depedencies and bump version.
@bsudekum
Copy link

bsudekum commented Jan 7, 2017

Besides fixing the headers, this adds RN@0.40 and React@15.4.0 as peer dependencies and bump version.

Is adding react and react native as a peer dependency necessary?

@sntran
Copy link
Contributor Author

sntran commented Jan 7, 2017

It breaks compatibility with older version of React Native. For this particular PR, React Native 0.40 is required, so I added it as peer dependency.

@aksonov
Copy link
Contributor

aksonov commented Jan 9, 2017

@sntran I'm still having compilation error about <React/RCTConvert+CoreLocation.h> file not found (within RCTMapboxGLConversions.h> with this PR, any other path/settings i should alter?

@aksonov
Copy link
Contributor

aksonov commented Jan 9, 2017

@sntran Maybe it is because CocoaPods settings were not changed?

@sntran
Copy link
Contributor Author

sntran commented Jan 9, 2017

I have always manually installed for iOS so I don't know about CocoaPods. I'll see what I can do.

@aksonov
Copy link
Contributor

aksonov commented Jan 9, 2017

@sntran Thanks - right, i've just checked with manual install - it works well! Unfortunately some libraries like latest iOS XMPP Framework have only CocoaPods install option...

@aksonov
Copy link
Contributor

aksonov commented Jan 9, 2017

Looks like RN0.40 cannot be installed via CocoaPods at all now - 'yoga' library is missed (PR is in progress as i see).

@sntran sntran mentioned this pull request Jan 11, 2017
@bsudekum
Copy link

bsudekum commented Feb 7, 2017

Thanks! I think the cocoapod failures could be fixed with #499

@bsudekum bsudekum merged commit 3df91c5 into nitaliano:master Feb 7, 2017
@ivankennethwang
Copy link

Any updates when can we have a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants