-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ スケジュール詳細画面を追加 #122
Merged
Merged
✨ スケジュール詳細画面を追加 #122
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
app/ios/Modules/Sources/Schedule/ComposeScheduleDetailScreen.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import KmpContainer | ||
import NitoKmp | ||
import SwiftUI | ||
import UIKit | ||
|
||
public struct ComposeScheduleDetailScreen: UIViewControllerRepresentable { | ||
private let scheduleId: String | ||
|
||
public init(scheduleId: String) { | ||
self.scheduleId = scheduleId | ||
} | ||
|
||
public func makeUIViewController(context: Context) -> UIViewController { | ||
return ScheduleDetailScreen_iosKt.ScheduleDetailRouteViewController( | ||
id: scheduleId, | ||
stateMachine: ScheduleDetailStateMachine( | ||
id: scheduleId, | ||
fetchParticipantScheduleById: Container.shared.get( | ||
type: FetchParticipantScheduleByIdUseCase.self), | ||
userMessageStateHolder: Container.shared.get(type: UserMessageStateHolder.self), | ||
dateTimeFormatter: Container.shared.get(type: CommonNitoDateFormatter.self) | ||
) | ||
) | ||
} | ||
|
||
public func updateUIViewController(_ uiViewController: UIViewController, context: Context) { | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...e/schedule/src/commonMain/kotlin/club/nito/feature/schedule/detail/ScheduleDetailEvent.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package club.nito.feature.schedule.detail | ||
|
||
public sealed class ScheduleDetailEvent { | ||
public data class NavigateToScheduleDetail(val scheduleId: String) : ScheduleDetailEvent() | ||
} |
9 changes: 9 additions & 0 deletions
9
.../schedule/src/commonMain/kotlin/club/nito/feature/schedule/detail/ScheduleDetailIntent.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package club.nito.feature.schedule.detail | ||
|
||
import club.nito.core.domain.model.ParticipantSchedule | ||
|
||
public sealed class ScheduleDetailIntent { | ||
public data class ClickParticipate(val schedule: ParticipantSchedule) : ScheduleDetailIntent() | ||
public data class ClickParticipateSchedule(val schedule: ParticipantSchedule) : ScheduleDetailIntent() | ||
public data object ClickDismissConfirmParticipateDialog : ScheduleDetailIntent() | ||
} |
26 changes: 26 additions & 0 deletions
26
...edule/src/commonMain/kotlin/club/nito/feature/schedule/detail/ScheduleDetailNavigation.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package club.nito.feature.schedule.detail | ||
|
||
import club.nito.core.model.schedule.ScheduleId | ||
import moe.tlaster.precompose.navigation.NavOptions | ||
import moe.tlaster.precompose.navigation.Navigator | ||
import moe.tlaster.precompose.navigation.RouteBuilder | ||
import moe.tlaster.precompose.navigation.path | ||
|
||
private const val ROUTE: String = "/schedules" | ||
|
||
public fun Navigator.navigateToScheduleDetail( | ||
id: ScheduleId, | ||
navOptions: NavOptions? = null, | ||
) { | ||
this.navigate("$ROUTE/$id", navOptions) | ||
} | ||
|
||
public fun RouteBuilder.scheduleDetailScreen() { | ||
scene( | ||
route = "$ROUTE/{id}", | ||
) { backStackEntry -> | ||
backStackEntry.path<String>("id")?.let { id -> | ||
ScheduleDetailRoute(id = id) | ||
} | ||
Comment on lines
+22
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. エラーハンドリングの追加を検討してください。 backStackEntry.path<String>("id")?.let { id ->
ScheduleDetailRoute(id = id)
} ?: run {
// 適切なエラーハンドリングをここに追加する
} |
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateUIViewController
メソッドが空です。これは、作成後にUIViewControllerを更新する必要がない場合に意図的なものかもしれませんが、もし将来的にUIViewControllerの状態を更新する必要が生じた場合に備えて、このメソッドの実装を検討するか、またはコメントを追加してその目的を明確にすることをお勧めします。