Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ アプリで使用するアイコンを定義 #142

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

tatsutakein
Copy link
Member

@tatsutakein tatsutakein commented Dec 10, 2023

Issue

  • close #ISSUE_NUMBER 🦕

概要

アプリで使用するアイコンを定義します。

レビュー観点

特になし

レビューレベル

  • Lv0: まったく見ないで Approve する
  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before After

Summary by CodeRabbit

  • 新機能
    • アイコンライブラリに「Visibility」と「VisibilityOff」の2つの新しいアイコンを追加しました。

@tatsutakein tatsutakein requested a review from a team as a code owner December 10, 2023 10:20
Copy link

coderabbitai bot commented Dec 10, 2023

Walkthrough

プロジェクトのbuild.gradle.ktsファイルにcompose.materialIconsExtendedの依存関係が追加されました。また、NitoIconsという新しいオブジェクトが作成され、VisibilityVisibilityOffというImageVector型の公開プロパティが導入されています。

Changes

ファイル 変更概要
core/designsystem/build.gradle.kts commonMainソースセットの依存関係にcompose.materialIconsExtendedを追加
.../core/designsystem/icon/NitoIcons.kt 新しい公開オブジェクトNitoIconsを追加し、VisibilityVisibilityOffImageVector型プロパティを導入

🐰✨
コードの野に一輪のアイコン咲く
見えるもの、見えぬもの、切り替わる景色
ラビットの手によって、新たな光を放つ
🌟👀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f57ac5b and 9480ca1.
Files selected for processing (2)
  • core/designsystem/build.gradle.kts (1 hunks)
  • core/designsystem/src/commonMain/kotlin/club/nito/core/designsystem/icon/NitoIcons.kt (1 hunks)
Files skipped from review due to trivial changes (1)
  • core/designsystem/build.gradle.kts
Additional comments: 1
core/designsystem/src/commonMain/kotlin/club/nito/core/designsystem/icon/NitoIcons.kt (1)
  • 1-11: 新しいアイコンVisibilityVisibilityOffNitoIconsオブジェクトに追加され、適切にIcons.Filledクラスから割り当てられています。この変更は問題なく見えます。

@tatsutakein tatsutakein merged commit d7a96d5 into main Dec 10, 2023
4 checks passed
@tatsutakein tatsutakein deleted the rt/add-icon branch December 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant