-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nito アイコンのリソースを追加 #278
Conversation
ウォークスルーこの変更では、Nitoデザインシステムに新しいドローアブルリソース 変更
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- core/designsystem/build.gradle.kts (1 hunks)
- core/designsystem/src/commonMain/kotlin/club/nito/core/designsystem/icon/NitoDrawables.kt (1 hunks)
Files skipped from review due to trivial changes (1)
- core/designsystem/src/commonMain/kotlin/club/nito/core/designsystem/icon/NitoDrawables.kt
@@ -14,6 +14,7 @@ kotlin { | |||
sourceSets { | |||
commonMain { | |||
dependencies { | |||
implementation(compose.components.resources) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compose.components.resources
の依存関係を追加する際に、バージョンを明示的に指定することをお勧めします。これにより、将来的にライブラリの自動更新による予期しない問題を防ぐことができます。
Issue
概要
nito アイコンのリソースを追加します.
レビュー観点
レビューレベル
レビュー優先度
参考リンク
スクリーンショット
Summary by CodeRabbit
Nito
ドローアブルリソースを提供する。