Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👍 NitoDateFormatter をカイゼン #72

Merged
merged 5 commits into from
Nov 25, 2023
Merged

👍 NitoDateFormatter をカイゼン #72

merged 5 commits into from
Nov 25, 2023

Conversation

tatsutakein
Copy link
Member

Issue

  • close #ISSUE_NUMBER 🦕

概要

NitoDateFormatter をカイゼンします。

レビュー観点

特になし

レビューレベル

  • Lv0: まったく見ないで Approve する
  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before After

@tatsutakein tatsutakein requested a review from a team as a code owner November 25, 2023 15:05
@tatsutakein tatsutakein merged commit 991f0fa into main Nov 25, 2023
3 checks passed
@tatsutakein tatsutakein deleted the rt/improve-datetimeformatter branch November 25, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tatsutakein tatsutakein

Labels
@app/ios iOS development @core/common @core/ui @feature/schedule @feature/top @type/improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tatsutakein