Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Firebase second generation #78

Open
wants to merge 2 commits into
base: firebase
Choose a base branch
from

Conversation

posva
Copy link
Collaborator

@posva posva commented Jul 14, 2023

Discussed with @pi0
Still needs to be deployed manually with firebase deploy by the owner to update functions

const onRequestDefaults = {
memory: "1GiB",
// TODO: does this change anything?
invoker: "public",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to enforce this otherwise the google cloud permissions aren't set properly, and they can only be changed with the gcloud cli (not the firebase cli or the dashboard)
We figured that out in the firebase-v2 pr preset

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is the kind of things that are hard to deal with in Firebase projects 😓 , it's the part that is not always document or easy to find

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I find weird is that it wasn't necessary in gen 1?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed the way permissions works at the gcloud level

@Hebilicious
Copy link
Collaborator

Do we want to test only one of the two presets, or both v1 or v2 ?

@posva
Copy link
Collaborator Author

posva commented Jul 15, 2023

I think testing just the latest gen is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants