fix: exclude typed body from cachedEventHandler (#1647)

nitrojs · Aug 26, 2023 · b470fd0 · b470fd0
1 parent a0e60fd
commit b470fd0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/runtime/cache.ts b/src/runtime/cache.ts
@@ -195,11 +195,11 @@ export function defineCachedEventHandler<
 >(
   handler: EventHandler<Request, Response>,
   opts?: CachedEventHandlerOptions<Response>
-): EventHandler<Request, Response>;
+): EventHandler<Omit<Request, "body">, Response>;
 // TODO: remove when appropriate
 // This signature provides backwards compatibility with previous signature where first generic was return type
 export function defineCachedEventHandler<
-  Request = EventHandlerRequest,
+  Request = Omit<EventHandlerRequest, "body">,
   Response = EventHandlerResponse,
 >(
   handler: EventHandler<

diff --git a/test/fixture/types.ts b/test/fixture/types.ts
@@ -279,6 +279,16 @@ describe("defineCachedEventHandler", () => {
       >
     >();
   });
+  it("should not allow typed input body", () => {
+    const b = defineCachedEventHandler<
+      { body: string },
+      Promise<{ message: string }>
+    >(fixture);
+    expectTypeOf(b).toEqualTypeOf<
+      // eslint-disable-next-line @typescript-eslint/ban-types
+      EventHandler<{}, Promise<{ message: string }>>
+    >();
+  });
   it("is backwards compatible with old generic signature", () => {
     const a = defineCachedEventHandler<
       Promise<{