Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pre-exisiting web.config iis_node #1628

Closed
1 task done
Hardaker587 opened this issue Aug 24, 2023 · 3 comments · Fixed by #1658
Closed
1 task done

Merge pre-exisiting web.config iis_node #1628

Hardaker587 opened this issue Aug 24, 2023 · 3 comments · Fixed by #1658
Labels

Comments

@Hardaker587
Copy link
Contributor

Hardaker587 commented Aug 24, 2023

Describe the feature

Thank you for bringing out the IIS presets! It's been long awaited but much appreciated - I do have one small issue that I would like to request a feature for:

  • During build, there needs to be a way to import an existing web.config file - right now I don't see any of my environment variables that would otherwise normally be in there.

Proposed solution:
Either merge the files together or generate the appsettings xml tag based on the runtimeConfig

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <appSettings>
    <add key="NODE_ENV" value="production" />
  </ appSettings>
</ configuration>

I'd be more than happy to give this a bash to resolve this for you

Additional information

  • Would you be willing to help implement this feature?
@pi0
Copy link
Member

pi0 commented Aug 24, 2023

Supporting override via iis.config (in nuxt/nitro config) would be nice!

Also we might automatically generate env section for defaults + runtime config wdyt?

@Hardaker587
Copy link
Contributor Author

Sounds amazing! I am currently writing the changes necessary to be able to cater for these things

First thing I am busy with at this point is merging the two different web.configs if one exists - like in my case

@Hardaker587
Copy link
Contributor Author

Added PR #1656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants