Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iis): merge web.config #1658

Merged
merged 13 commits into from
Sep 7, 2023
Merged

fix(iis): merge web.config #1658

merged 13 commits into from
Sep 7, 2023

Conversation

Hardaker587
Copy link
Contributor

πŸ”— Linked issue

Resolves #1628

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@pi0 Adding additional functionality to #1436 in order to prevent breaking changes for those already integrated with IIS

Note: I reapplied the changes as there was my web.config in the original commits

Additional notes:

  • I will be adding in another PR, the functionality to generate the environment variables from runtimeConfigs.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Aug 28, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview d166717

@pi0 pi0 changed the title Add web.config merging for IIS presets fix(iis): merge web.config Aug 29, 2023
@pi0
Copy link
Member

pi0 commented Sep 6, 2023

Sorry it took long to check on this @Hardaker587. I will make local review maybe adding changes to make XML lib optional. (you don't need to rebase on each commit)

@Hardaker587
Copy link
Contributor Author

Sorry it took long to check on this @Hardaker587. I will make local review maybe adding changes to make XML lib optional. (you don't need to rebase on each commit)

Thanks so much - just been making sure my fork is up to date with the latest :)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Made a couple of refactors to make XML dependency optional (you have to install it in your project). I hope you are happy with the changes otherwise feel free to make an amended PR.

@pi0 pi0 merged commit 5639f5b into nitrojs:main Sep 7, 2023
6 checks passed
@Hardaker587
Copy link
Contributor Author

Thanks. Made a couple of refactors to make XML dependency optional (you have to install it in your project). I hope you are happy with the changes otherwise feel free to make an amended PR.

Perfect, I will make a PR with amended docs to reflect this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge pre-exisiting web.config iis_node
2 participants