Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly specify multiple external dependencies in package.json #1013

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix: correctly specify multiple external dependencies in package.json #1013

merged 1 commit into from
Mar 3, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Mar 3, 2023 •
edited
Loading

🔗 Linked issue

Fixes nuxt/nuxt#19436.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a small typo introduced in #782: according to https://github.com/npm/node-semver#ranges, two different versions are joined by || and not only a single |.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@tobiasdiez tobiasdiez mentioned this pull request Mar 3, 2023
Closed
pi0
pi0 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 9e38bd2 into nitrojs:main Mar 3, 2023
@tobiasdiez tobiasdiez deleted the patch-1 branch March 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated server package.json contains invalid version specification
3 participants
@tobiasdiez @pi0 @danielroe