fix(externals): absolute paths are inlined #1429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Discovered while trying to make reproduction tests for #527.
Normally importing a library with a subpath like
@fixture/nitro-utils/extra
correctly creates an externals chunk in.output/server/node_modules/@fixture/nitro-utils/extra.mjs
. But we wrongly inline if this path is absolute for any reason (like using aliases).This PR fixes this by using a default scoring assigned to include/exclude patterns based on their length (function patterns have highest priority always). When an inline rule conflicts with an external, it will be only applied if is more precise and also by adding all
node_modules
as externals by default.π Checklist