Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-pages): prerender / by default #2334

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix(github-pages): prerender / by default #2334

merged 1 commit into from
Apr 3, 2024

Conversation

sby1ce
Copy link
Contributor

@sby1ce sby1ce commented Apr 3, 2024

πŸ”— Linked issue

fixes #2333

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

resolves #2333 . adds "/" to the list of prerendered routes for github-pages preset

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: github-pages preset fix fix(github-pages): prerender / by default Apr 3, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 8b5cbc5 into nitrojs:main Apr 3, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Jun 13, 2024
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root "/" doesn't get prerendered with Github Pages preset
2 participants