feat(netlify): experimental support v2 functions ISR via targeted cache-control headers #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
May 1, 2024
8 tasks
pi0
changed the title
pi0
changed the title
Previously, ISR in Nitro had been implemented on Netlify via its proprietary [On-Demand Builders](https://docs.netlify.com/configure-builds/on-demand-builders/) platform primitive. Now that there's momentum around [Targeted HTTP Cache Control](https://httpwg.org/specs/rfc9213.html) and that [Netlify supports it](https://docs.netlify.com/platform/caching/#supported-cache-control-headers), we can implement ISR in Nitro via these simple, standard HTTP headers instead. By virtue of switching to the standard Netlify Functions interface, this also happens to: - allow streaming responses - add better support for "hybrid rendering", e.g. if you set `prerender: true` on a specific route, that will actually work as intended now - remove the imposed 60s delay after a background generation request before which the new response will be served for subsequent requests (this was an ODB limitation) - fix a bug where we were setting `set-cookie: undefined` on responses - remove usage of an undocumented `functions-internal/server.json` Netlify config file - ... which wasn't working when using `netlify dev` in local development anyway This also configures a human-friendly name and some metadata on the function. Supersedes nitrojs#1823. Closes nitrojs#1842. Closes nitrojs#1938.
pi0
force-pushed
the
serhalp/fra-356-update-nitro-to-use-v2-functions
branch
from
2fc17ff
to
2c106d9
Compare
Rigo-m
reviewed
May 1, 2024
|
Super @serhalp 😍 |
pi0
force-pushed
the
serhalp/fra-356-update-nitro-to-use-v2-functions
branch
from
1754331
to
5f02fea
Compare
pi0
changed the title
pi0
changed the title
pi0
approved these changes
May 7, 2024
8 tasks
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Supersedes #1823.
Closes #1842.
Closes #1938.
❓ Type of change
📚 Description
Netlify introduced a new Functions interface last year. This updates Nitro to use this interface.
Previously, ISR in Nitro had been implemented on Netlify via its proprietary On-Demand Builders platform primitive, which only supports "v1" Functions. Now that there's momentum around Targeted HTTP Cache Control and that Netlify supports it, we can implement ISR in Nitro via these simple, standard HTTP headers instead.
By virtue of switching to the standard Netlify Functions interface, this also happens to:
prerender: trueon a specific route, that will actually work as intended nowset-cookie: undefinedon responsesfunctions-internal/server.jsonNetlify config filenetlify devin local development anywayThis also configures a human-friendly name and some metadata on the function.
Note: I removed the
netlify_builderpreset, since there's no reason to use this anymore. I'm not even sure why it was ever exposed as a preset. I did this as a separate commit, so if you consider this a breaking change I can pull it out into a separate PR.📝 Checklist