Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): add x-forwarded headers #247

Merged
merged 3 commits into from
Jun 12, 2022
Merged

Conversation

abdullrahman02000
Copy link
Contributor

This is very important since every reverse proxy should provide a way sending client ip, port, ip family.
It caused issue in nuxt3 which uses nitro because it is not possible to get client info in development mode

I am sorry I did not add more details, It is the first time I contribute, I have already modified it on my PC and tested it.
Look at this link:
https://github.com/http-party/node-http-proxy#listening-for-proxy-events

This is very important since every reverse proxy should provide a way sending client ip, port, ip family.
It caused issue in nuxt3 which uses nitro because it is not possible to get client info in development mode
@pi0 pi0 changed the title Adding x-headers to proxy request feat(dev): add x-forwarded headers May 17, 2022
@pi0 pi0 merged commit 2d50312 into nitrojs:main Jun 12, 2022
@pi0
Copy link
Member

pi0 commented Jun 12, 2022

Thanks!

WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants