Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): infer types correctly when method is omitted #2551

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(types): infer types correctly when method is omitted #2551

merged 1 commit into from
Jun 20, 2024

Conversation

danielroe
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Related: #2550

This fixes the types for $fetch when a method is omitted.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types labels Jun 20, 2024
@danielroe danielroe self-assigned this Jun 20, 2024
@pi0 pi0 merged commit f76d21b into v2 Jun 20, 2024
5 checks passed
@pi0 pi0 deleted the fix/method-type branch June 20, 2024 21:25
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@danielroe @pi0
fix(types): infer types correctly when method is omitted (#2551)
2dbd4bb
@pi0 pi0 mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0