Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve aliases with reference to themselves #26

Merged
merged 5 commits into from
Mar 29, 2022
Merged

feat: resolve aliases with reference to themselves #26

merged 5 commits into from
Mar 29, 2022

Conversation

danielroe
Copy link
Member

this allows us to pass an alias in like nitroOptions.alias['#nitro-renderer'] = '#nitro/vue/vue2' and have it resolved properly.

@danielroe danielroe requested a review from pi0 March 29, 2022 19:25
@danielroe danielroe self-assigned this Mar 29, 2022
@pi0
Copy link
Member

pi0 commented Mar 29, 2022

Shouldn't rollup plugin handle nested aliases?

@danielroe
Copy link
Member Author

Hm. You would think so, but it doesn't. Are you thinking a PR to it?

@pi0
Copy link
Member

pi0 commented Mar 29, 2022

Sure! A PR would be probably nice. In the meantime we can keep using what rollup support. Do you think it would help to have a utility like this in meantime?

@pi0 pi0 merged commit adb6c5d into main Mar 29, 2022
@pi0 pi0 deleted the fix/aliases branch March 29, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants