feat(service-worker): inject SW registeration script to all pages #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnabaz
commented
Jun 20, 2022
src/presets/service-worker.ts
Outdated
| @@ -55,6 +49,11 @@ export const serviceWorker = defineNitroPreset(() => { | |||
| preview: 'npx serve ./public' | |||
| }, | |||
| hooks: { | |||
| 'prerender:route' (route) { | |||
| // TODO: use baseURL from nitro options | |||
| const baseURL = '/' | |||
There was a problem hiding this comment.
@pi0 @danielroe Is there any way to access nitro inside presets other than passing it to hook?
There was a problem hiding this comment.
No. Presets are evaluated for constructing config. We might improve this by supporting lazy evaluated hooks but for now you can directly pass nireo as second argument 👍🏼
|
Any updates on this? |
|
@pi0 I updated hook signature and passed |
pi0
reviewed
Jun 23, 2022
pi0
changed the title
pi0
approved these changes
Jun 29, 2022
pi0
changed the title
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #88
❓ Type of change
📚 Description
📝 Checklist