feat: allow specifying wasm plugin options #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Aug 31, 2022
pi0
changed the title
|
Jaha, I thought so, too. But spreading a boolean is not allowed, sadly. |
|
Try this |
|
I tried that too before and saw that it works just fine. Only TS is not allowing it. I don't know if you accept |
pi0
reviewed
Aug 31, 2022
|
We can also use |
|
Thanks! |
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using nitro in Nuxt 3 and I found that the default options only work when the WASM file is smaller than the default inlining-threshold. Otherwise the Nuxt3 NodeJS server environment (and other server targets I'd imagine) chokes on the wasm plugin using
require()calls (how dare them userequirein NodeJS! :D). And even if that would be fixed upstream in the@rollup/plugin-wasmpackage, it's still nice to be able to change the default options here.