fix(prerender): check link's pathname only for extensions #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a link contains parts following the pathname, e.g. a query or hash, the file extension would not be found. Links that appear to have no file extension would then NOT be excluded from crawling. Those included links led the crawler to request, e.g. static, files on which `vue-bundle-renderer` would produce a memory overflow.
Codecov Report
@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 57 57
Lines 5229 5230 +1
Branches 575 575
=======================================
+ Hits 3664 3665 +1
Misses 1556 1556
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danielroe
approved these changes
Dec 31, 2022
|
Next year π Right now I have for you:
Happy New Year! π |
|
Thanks β€οΈ |
pi0
pushed a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
n/a, see description below
β Type of change
π Description
If a link contains parts following the pathname, e.g. a query or hash, the file extension would not be found. Links that appear to have no file extension would then NOT be excluded from crawling. Those included links led the crawler to request, e.g. static, files on which
vue-bundle-renderer(as used in Nuxt) would produce a memory overflow.I did not investigate the reason for the overflow being an overflow further as the link usage is incorrect in the first place.
π Checklist