Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve vfs ui #802

Merged
merged 3 commits into from
Jan 9, 2023
Merged

fix: improve vfs ui #802

merged 3 commits into from
Jan 9, 2023

Conversation

antfu
Copy link
Collaborator

@antfu antfu commented Jan 3, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changes:

  • Make <body> full height, using grid - to make the editor and file list scroll independently.
  • Improve FOUC of CSS
  • Fix editor initialize flick (sometimes the editor is initialized with only 5px height)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #802 (af2dc4a) into main (45b3abd) will decrease coverage by 0.00%.
The diff coverage is 3.84%.

❗ Current head af2dc4a differs from pull request most recent head 1f76f30. Consider uploading reports for the commit 1f76f30 to get more accurate results

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   69.96%   69.95%   -0.01%     
==========================================
  Files          57       57              
  Lines        5257     5246      -11     
  Branches      580      576       -4     
==========================================
- Hits         3678     3670       -8     
+ Misses       1571     1567       -4     
- Partials        8        9       +1
Impacted Files Coverage Ξ”
src/dev/vfs.ts 10.09% <3.84%> (+<0.01%) ⬆️
src/build.ts 45.00% <0.00%> (-1.82%) ⬇️
src/presets/cloudflare.ts 55.35% <0.00%> (-1.79%) ⬇️
src/presets/netlify.ts 59.14% <0.00%> (-1.22%) ⬇️
src/rollup/plugins/server-assets.ts 82.50% <0.00%> (-0.84%) ⬇️
src/compress.ts 91.33% <0.00%> (-0.79%) ⬇️
src/utils/index.ts 51.30% <0.00%> (ΓΈ)
src/presets/vercel.ts 77.11% <0.00%> (ΓΈ)
src/rollup/config.ts 91.58% <0.00%> (+0.70%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antfu antfu mentioned this pull request Jan 6, 2023
Closed
11 tasks
pi0
pi0 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have tried to manually rebase conflicts and locally works fine. But please mention if missed anything.

@pi0 pi0 merged commit dcc59c7 into main Jan 9, 2023
@pi0 pi0 deleted the fix/improve-vfs branch January 9, 2023 15:40
pi0 pushed a commit that referenced this pull request Jan 16, 2023
@antfu @pi0
fix(dev): improve vfs ui (#802)
acc298c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @pi0