Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update event. to event.node. #828

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

cpreston321
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This will resolve deprecated use of event.req|res to the new way which is event.node. To make sure it stays up to date.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #828 (a6e3a3a) into main (15edef0) will not change coverage.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   69.83%   69.83%           
=======================================
  Files          57       57           
  Lines        5291     5291           
  Branches      585      585           
=======================================
  Hits         3695     3695           
  Misses       1588     1588           
  Partials        8        8           
Impacted Files Coverage Ξ”
src/dev/error.ts 11.11% <0.00%> (ΓΈ)
src/dev/server.ts 74.79% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe requested a review from pi0 January 11, 2023 09:41
@pi0 pi0 changed the title chore(nitro): update deprecated event.req|res -> event.node.req|res refactor: update event. to event.node. Jan 11, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. (on a related note, the main goal of deprecating was to encourage using utilities instead of interacting with low-level req/res. we can progressively do this)

@pi0 pi0 merged commit 5d5b62e into nitrojs:main Jan 11, 2023
@cpreston321 cpreston321 deleted the fix/depercatedEventContext branch January 12, 2023 06:07
pi0 pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants