fix(externals): use stable dependency tree #909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR improves Nitropack v2 externals tracker by analyzing dependency tree between packages in multi phases:
node_modules
node_modules/.nitro/name@version
node_modules/.nitro/mv_parent}/node_modules/{name}
node_modules/{sv_parent}/node_modules/{name}
This solves concurrency issue, improves performance and handling hoisting for hoisted versions (tested against nice reproduction provided by @itpropro against
"@azure/app-configuration": "^1.3.1"
+"@azure/search-documents": "^11.3.1"
+"@azure/identity": "^3.1.3"
with conflicting@azure/core-tracing
(1.0.1/1.0.0-preview.13)π Checklist