Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: move to its own module and disable re-registration by default #119

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Jul 15, 2022

Due to the amount of side-effects that touching the binfmt registrations introduces (no interop in other distros, broken WSLg, etc) it is now disabled by default. When the configuration contains another binfmt registration (and would therefore break interop) a warning is issued during evaluation

@K900

Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this conceptually, but I don't think we can really fix it without help from upstream.

The actual diff LGTM.

@nzbr
Copy link
Member Author

nzbr commented Jul 15, 2022

Once microsoft/WSL#8203 is resolved, we can enable it by default again. This is just meant as a temporary fix

@nzbr nzbr changed the title interop: move to its own module and disable by default interop: move to its own module and disable re-registration by default Jul 15, 2022
@nzbr nzbr added the bug Something isn't working label Jul 15, 2022
@nzbr nzbr merged commit cc4888f into nix-community:main Jul 15, 2022
@nzbr nzbr deleted the interop-module branch July 15, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants