fix: explicitly add systemctl and grep to path in shell-wrapper #240
Conversation
We can generally find them in /run/current-system/sw/bin, but WSL may try to call those before activation is fully done, so make sure it can always find what it needs.
| @@ -4,6 +4,7 @@ with lib; | |||
|
|
|||
| let | |||
| bashWrapper = pkgs.writeShellScriptBin "sh" '' | |||
| export PATH=${lib.makeBinPath [ pkgs.systemd pkgs.gnugrep ]} | |||
| . ${config.system.build.etc}/etc/set-environment | |||
There was a problem hiding this comment.
Doesn't this PATH get set here? Not sure where a command should be executed here. I am probably missing some context
There was a problem hiding this comment.
/etc/set-environment sets PATH to /run/current-system/sw/bin, but the /run/current-system symlink might not exist when WSL first tries to systemctl | grep things.
There was a problem hiding this comment.
hmmm, I see. We should comment that.
| @@ -4,6 +4,7 @@ with lib; | |||
|
|
|||
| let | |||
| bashWrapper = pkgs.writeShellScriptBin "sh" '' | |||
| export PATH=${lib.makeBinPath [ pkgs.systemd pkgs.gnugrep ]} | |||
There was a problem hiding this comment.
| export PATH=${lib.makeBinPath [ pkgs.systemd pkgs.gnugrep ]} | |
| export PATH=${lib.makeBinPath with pkgs; [ systemd gnugrep ]} |
|
If we're doing that, shouldn't we just add |
|
I'm not sure, I'd rather have the bare minimum needed by the WSL machinery here and handle the rest in a way that's as conventional as possible. |
|
We could also just put a busybox in there. That would be future-proof as well and less easy to brick by changing the system config |
|
They do call systemctl, so we can't just put a busybox in there. |
|
Right, I meant that more as "instead of |
|
I'm 100% expecting WSL to assume gnugrep there tbh. |
We can generally find them in /run/current-system/sw/bin, but WSL may try to call those before activation is fully done, so make sure it can always find what it needs.