Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start menu launchers rsync of directory symlinks #380

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Jan 3, 2024

When using a profile containing icons having a symlink such as:

/etc/profiles/per-user/USER/share/icons/hicolor -> /nix/store/fvlvfdkc9hh7icadwqxfiazifmsxprrl-home-manager-path/share/icons/hicolor

The merge of several rsync sources doesn't work properly. With this fix it will copy the symlinked directory instead and in that way support the rsync.

@terlar
Copy link
Contributor Author

terlar commented Jan 4, 2024

This doesn't have conflicts and didn't touch the same lines as the other change after all, so I guess no need to rebase.

@nzbr nzbr added the bug Something isn't working label Jan 5, 2024
@nzbr nzbr merged commit d2fd320 into nix-community:main Jan 5, 2024
20 checks passed
@terlar terlar deleted the fix-rsync-of-dir-symlinks branch January 5, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants