master: Add config to force https for the endpoint #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 21804eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me preface this by saying I'm new to Nix, so sorry if I've missed something obvious and there's another way around this. Also, thank you for your work on this module!
I'm setting up a buildbot instance using buildbot-nix and I ran into a usecase that isn't currently handled by the module. My buildbot is behind a third party proxy that does TLS termination for me, so I don't need nginx to create or serve any certificates, but there's no way to let the module know that the endpoint must start with
https://because this is currently tied to the nginx configuration. This patch adds a config option to make the endpoint usehttps://even if it's not setup in nginx.