polybar: use recursive config type #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berbiche
approved these changes
Aug 17, 2021
berbiche
reviewed
Aug 17, 2021
berbiche
reviewed
Oct 12, 2021
modules/services/polybar.nix
Outdated
| @@ -112,7 +112,9 @@ in { | |||
| }; | |||
|
|
|||
| settings = mkOption { | |||
| type = types.attrsOf types.attrs; | |||
| type = with types; | |||
| let ty = oneOf [ bool int str (listOf ty) (attrsOf ty) ]; | |||
There was a problem hiding this comment.
Shouldn't it also include floats?
Allow merging of lists and attrsets
arcnmx
force-pushed
the
polybar-merge
branch
from
b30d6f3
to
c48f635
Compare
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Nov 29, 2021
Allow merging of lists and attrsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow merging of lists and attrsets in polybar configs.
(I believe I need to set a description or something to fix recursive types in the docs, what do I need to do again?)
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.