Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implements #4485
I added the
programs.zellij.layouts
which can contain name value pairs. The name is the name of the layout, while the value is the string being written to the respective layout file. The config would look as follows:This way of configuring layouts is somewhat suboptimal, since it doesn't use the
toKDL
parser. However, afaik, it is currently impossible to generate configs like:which are perfectly valid
kdl
configs.As such, this implementation is not forward compatible as an improved
toKDL
function would deprecate defining layouts as a string. I see two options forward:toKDL
function (I'll probably create a PR to discuss such a change)This is not covered by #4465.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@emilazy @foo-dogsquared @erikkrieg @h7x4