Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zen-browser: add module #6012

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HeitorAugustoLN
Copy link
Member

Description

Adds zen-browser module, there is currently an open PR for the package at NixOS/nixpkgs#347222

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

@DOD-101
Copy link

DOD-101 commented Dec 10, 2024

New PR is this one: NixOS/nixpkgs#363992

@NikSneMC
Copy link
Contributor

Seems like Zen marks profile as invalid if there's no ZenAvatarPath in it's definition

@HeitorAugustoLN
Copy link
Member Author

Seems like Zen marks profile as invalid if there's no ZenAvatarPath in it's definition

Yeah, I know, it is just a draft PR for now, I will continue it after the package is available, which will take some time.

@NikSneMC
Copy link
Contributor

Seems like Zen marks profile as invalid if there's no ZenAvatarPath in it's definition

Yeah, I know, it is just a draft PR for now, I will continue it after the package is available, which will take some time.

I think you can use packages from user flakes to test module

@HeitorAugustoLN
Copy link
Member Author

I think you can use packages from user flakes to test module

Some features could be tested, but not all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants