vivid: add module #6045
Open
vivid: add module #6045
+142
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folliehiyuki
reviewed
Nov 6, 2024
|
@folliehiyuki Hej, I just wanted to check if the PR is alright. It is my first in the |
| "set -gx LS_COLORS (${lib.getExe pkgs.vivid} generate ${theme})"; | ||
| nushellLine = theme: "${lib.getExe pkgs.vivid} generate ${theme}"; | ||
| zshLine = bashLine; | ||
| in { |
There was a problem hiding this comment.
You can put a with lib; declaration here, so usages of lib afterward can be shorten.
| }; | ||
|
|
||
| theme = lib.mkOption { | ||
| type = lib.types.nullOr lib.types.str; |
There was a problem hiding this comment.
Suggested change
| type = lib.types.nullOr lib.types.str; | |
| type = with types; nullOr str; |
assuming that with lib; was declared above.
There was a problem hiding this comment.
The same goes for the other options as well.
|
Can you also write a couple of assert tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add module for https://github.com/sharkdp/vivid.
Previous PRs #2194 and #3705 addressed this, but never merged.
The
themesandfiletypessection were taken from #2194.The integrations are used, since the variable name needs to be set to the output of the
vivid generate <theme>command. One could utilize what #2194 used:but this wouldn't be correct for
fishandnushell.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC