plugins/fidget: adapt to latest rewrite of the plugin #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #818 |
traxys
requested changes
Dec 28, 2023
There was a problem hiding this comment.
I'd say some options lack documentations, as it is not explained what false does for progress.pollRate.
There are more details in https://github.com/j-hui/fidget.nvim/blob/main/doc/fidget-option.txt, maybe we should include a bit more documentation (maybe not everything though, I don't know?)
|
I added the complete description of all options. |
Good catch. |
traxys
approved these changes
Dec 29, 2023
This was referenced Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fidget.nvim has been rewritten.
Hence, the options have changed significantly.
This PR updates our module to fit the upstream options.