Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing getifaddrs #650

Closed
mwanner opened this issue Jul 6, 2017 · 1 comment
Closed

missing getifaddrs #650

mwanner opened this issue Jul 6, 2017 · 1 comment
Labels
A-features

Comments

@mwanner
Copy link
Contributor

mwanner commented Jul 6, 2017

I implemented a trivial wrapper around getifaddrs, which I'd like to polish and get into the nix crate, if that's appropriate. Any specific requirements regarding the interface? Otherwise I'd prepare something based on an Iterator over the entries returned.
@Susurrus
Copy link
Contributor

Susurrus commented Jul 6, 2017

Thanks for volunteering your work! I'm sure that interface you find usable will be fine. It can also be modified later if it's hard to use in a specific use case. We do like to have good documentation and tests, so please spend some time on that so that it's easy to use.

mwanner pushed a commit to mwanner/nix that referenced this issue Jul 10, 2017
Add support for getifaddrs. Closes: nix-rust#650.
ad47c0b
@mwanner mwanner mentioned this issue Jul 27, 2017
Merged
mwanner pushed a commit to mwanner/nix that referenced this issue Nov 21, 2017
@mwanner
Add support for getifaddrs. Closes: nix-rust#650.
f1e5db7
mwanner added a commit to mwanner/nix that referenced this issue Nov 21, 2017
@mwanner
Add support for getifaddrs. Closes: nix-rust#650.
3711dea
mwanner added a commit to mwanner/nix that referenced this issue Dec 3, 2017
@mwanner
Add support for getifaddrs. Closes: nix-rust#650.
8dc8137
mwanner added a commit to mwanner/nix that referenced this issue Dec 3, 2017
@mwanner
Add support for getifaddrs. Closes: nix-rust#650.
985ea01
bors bot added a commit that referenced this issue Dec 4, 2017
@bors
Merge #667
3871586 
667: Add support for getifaddrs. r=asomers a=mwanner

Here's a first attempt at a rustian interface for `getifaddrs`, please review.

Changes for the changelog:

- Added `nix::ifaddrs::{getifaddrs, InterfaceAddressIterator,
  InterfaceAddress and InterfaceFlags}`

Closes #650.
Closes #764.
@bors bors bot closed this as completed in #667 Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwanner @Susurrus