Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable getregs/setregs on x86_64 musl #1198

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

coord-e
Copy link
Contributor

@coord-e coord-e commented Mar 19, 2020

Hi, I needed ptrace::getregs in my project. I noticed that they're only enabled on glibc while they can be compiled with musl. This PR enables getregs/setregs on x86_64 musl libc environment.

coord-e added a commit to coord-e/nix that referenced this pull request Mar 19, 2020
coord-e added a commit to coord-e/nix that referenced this pull request Mar 19, 2020
@coord-e coord-e changed the title Enable getregs/setregs on musl Enable getregs/setregs on x86_64 musl Mar 19, 2020
@asomers
Copy link
Member

asomers commented Mar 27, 2020

This looks good; now please squash your commits. The CI failure I think is caused by a bug in glibc.

coord-e added a commit to coord-e/nix that referenced this pull request Mar 28, 2020
@coord-e
Copy link
Contributor Author

coord-e commented Mar 28, 2020

Squashed and pushed. Thanks

@asomers
Copy link
Member

asomers commented Apr 1, 2020

Sorry, but you'll have to rebase. Some other PR just made a conflict.

coord-e added a commit to coord-e/nix that referenced this pull request Apr 1, 2020
@coord-e
Copy link
Contributor Author

coord-e commented Apr 1, 2020

That's OK, I've rebased

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 1, 2020

Build succeeded

@bors bors bot merged commit 627dff9 into nix-rust:master Apr 1, 2020
@coord-e coord-e deleted the musl-getregs-setregs branch April 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants