-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable getregs/setregs on x86_64 musl #1198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coord-e
added a commit
to coord-e/nix
that referenced
this pull request
Mar 19, 2020
coord-e
added a commit
to coord-e/nix
that referenced
this pull request
Mar 19, 2020
coord-e
force-pushed
the
musl-getregs-setregs
branch
from
March 19, 2020 17:37
b47bd57
to
ae5b6d6
Compare
coord-e
changed the title
Enable getregs/setregs on musl
Enable getregs/setregs on x86_64 musl
Mar 19, 2020
This looks good; now please squash your commits. The CI failure I think is caused by a bug in glibc. |
coord-e
added a commit
to coord-e/nix
that referenced
this pull request
Mar 28, 2020
Update CHANGELOG for nix-rust#1198
coord-e
force-pushed
the
musl-getregs-setregs
branch
from
March 28, 2020 06:35
ae5b6d6
to
6c57c10
Compare
Squashed and pushed. Thanks |
Sorry, but you'll have to rebase. Some other PR just made a conflict. |
coord-e
added a commit
to coord-e/nix
that referenced
this pull request
Apr 1, 2020
Update CHANGELOG for nix-rust#1198
coord-e
force-pushed
the
musl-getregs-setregs
branch
from
April 1, 2020 15:27
6c57c10
to
13cce09
Compare
Update CHANGELOG for nix-rust#1198
coord-e
force-pushed
the
musl-getregs-setregs
branch
from
April 1, 2020 15:28
13cce09
to
87047fc
Compare
That's OK, I've rebased |
asomers
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed
ptrace::getregs
in my project. I noticed that they're only enabled on glibc while they can be compiled with musl. This PR enables getregs/setregs on x86_64 musl libc environment.