Add support for SockAddr::Link when receiving packets
#1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Nov 27, 2020
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| - Added `mremap` (#[1306](https://github.com/nix-rust/nix/pull/1306)) | |||
| ### Changed | |||
| ### Fixed | |||
| - Fixed calling `recvfrom` on an `AddrFamily::Packet` socket (#[1344](https://github.com/nix-rust/nix/pull/1344)) | |||
| @@ -1719,6 +1719,15 @@ pub fn sockaddr_storage_to_addr( | |||
| Ok(SockAddr::Unix(UnixAddr(sun, pathlen))) | |||
| } | |||
| #[cfg(any(target_os = "android", target_os = "linux"))] | |||
There was a problem hiding this comment.
Err, wait on that. Fuchsia support hasn't merged yet.
There was a problem hiding this comment.
While the Fuchsia's libc (being a based on a Musl fork) has the defines and structures, I don't think it actually supports raw packet sockets (based on a cursory glance of it's own API) and that they're really just relics of the fork. But given that it's in their libc might be enough of a reason to support it.
|
I'm afraid you'll need to rebase to fix the CHANGELOG. |
|
@asomers is there anything left I can do to get this over the finish line? |
asomers
approved these changes
Jan 31, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1343