Mark most C-derived enums as non_exhaustive #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since libc may add new variants at any time, Nix's consumers should not use exhaustive match patterns. Fixes nix-rust#1182
jgallag88
added a commit
to jgallag88/ptools
that referenced
this pull request
Apr 27, 2022
Update everything to latest except for nix. In nix v0.23, a number of enums were marked #[non_exhaustive] (nix-rust/nix#1474). Since we want exhaustive matches in some cases, we will use v0.22 until non_exhaustive_omitted_patterns_lint is stablized (rust-lang/rust#89554)
jgallag88
added a commit
to jgallag88/ptools
that referenced
this pull request
Apr 27, 2022
Update everything to latest except for nix. In nix v0.23, a number of enums were marked #[non_exhaustive] (nix-rust/nix#1474). Since we want exhaustive matches in some cases, we will use v0.22 until non_exhaustive_omitted_patterns_lint is stablized (rust-lang/rust#89554)
jgallag88
added a commit
to jgallag88/ptools
that referenced
this pull request
Apr 27, 2022
Update everything to latest except for nix. In nix v0.23, a number of enums were marked #[non_exhaustive] (nix-rust/nix#1474). Since we want exhaustive matches in some cases, we will use v0.22 until non_exhaustive_omitted_patterns_lint is stablized (rust-lang/rust#89554)
jgallag88
added a commit
to jgallag88/ptools
that referenced
this pull request
Apr 28, 2022
Update everything to latest except for nix. In nix v0.23, a number of enums were marked #[non_exhaustive] (nix-rust/nix#1474). Since we want exhaustive matches in some cases, we will use v0.22 until non_exhaustive_omitted_patterns_lint is stablized (rust-lang/rust#89554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libc may add new variants at any time, Nix's consumers should not
use exhaustive match patterns.
Fixes #1182