Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the sockaddr interface: #1614

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Improve the sockaddr interface: #1614

merged 1 commit into from
Dec 24, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Dec 23, 2021

  • All sockaddr newtypes should be repr(transparent)
  • All sockaddr newtypes should be opaque, so the user can't do something
    like change the sa_family field in a way that violates invariants.

This is a prerequisite for #1544.

@asomers
Improve the sockaddr interface:
867ac51 
* All sockaddr newtypes should be repr(transparent)
* All sockaddr newtypes should be opaque, so the user can't do something
  like change the sa_family field in a way that violates invariants.

This is a prerequisite for nix-rust#1544.
@asomers
Copy link
Member Author

asomers commented Dec 24, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 24, 2021

Build succeeded:

@bors bors bot merged commit 7be98a4 into nix-rust:master Dec 24, 2021
@jamessan jamessan mentioned this pull request Jun 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asomers @rtzoeller