Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change port used by test_txtime to avoid conflict #1630

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Change port used by test_txtime to avoid conflict #1630

merged 1 commit into from
Jan 11, 2022

Conversation

rtzoeller
Copy link
Collaborator

The socket tests request specific ports, and test_timestamping and test_txtime are currently conflicting in the port they request.

This leads to the second of the tests failing with EADDRINUSE when run locally.

@rtzoeller rtzoeller requested a review from asomers January 11, 2022 04:02
asomers
asomers approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 11, 2022

Build succeeded:

@bors bors bot merged commit f8e2750 into nix-rust:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtzoeller @asomers