Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pin nightly compiler used in CI for uclibc" #1699

Merged
merged 1 commit into from
May 11, 2022
Merged

Revert "Pin nightly compiler used in CI for uclibc" #1699

merged 1 commit into from
May 11, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented Apr 19, 2022

This reverts commit 23f18df.

libc v0.2.124 fixes the problem.

@asomers
Revert "Pin nightly compiler used in CI for uclibc"
c5927f3 
This reverts commit 23f18df.

libc v0.2.124 fixes the problem.
@asomers asomers requested a review from rtzoeller April 19, 2022 02:24
@rtzoeller
Copy link
Collaborator

Is there a way to tell which build of nightly was used?

@asomers
Copy link
Member Author

asomers commented Apr 19, 2022

We'd probably have to add a rustc --version somewhere in there. I guess this means we can't merge until after the next rustc release, that includes this libc.

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Apr 21, 2022
@bors
Try #1699:
f539e0d
@bors
Copy link
Contributor

bors bot commented Apr 21, 2022

try

Build failed:

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Apr 22, 2022
@bors
Try #1699:
68d0470
@bors
Copy link
Contributor

bors bot commented Apr 22, 2022

try

Build failed:

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request May 2, 2022
@bors
Try #1699:
45cf0e0
@bors
Copy link
Contributor

bors bot commented May 2, 2022

try

Build failed:

@rtzoeller
Copy link
Collaborator

@skrap any idea on the current status of uclibc support on nightly? I've seen a few related PRs, some merged and some apparently inactive.

@skrap
Copy link
Contributor

skrap commented May 2, 2022

@skrap any idea on the current status of uclibc support on nightly? I've seen a few related PRs, some merged and some apparently inactive.

Thanks for the mention! I'll have a look today and see what needs to be pushed forward.

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request May 7, 2022
@bors
Try #1699:
4b73c7b
@bors
Copy link
Contributor

bors bot commented May 7, 2022

try

Build failed:

@rtzoeller
Copy link
Collaborator

Was hoping this was fixed by the libc bump in rust-lang/rust#96510. :/

@skrap
Copy link
Contributor

skrap commented May 7, 2022

Was hoping this was fixed by the libc bump in rust-lang/rust#96510. :/

Hm, it does build with cargo +nightly build -Zbuild-std --target armv7-unknown-linux-uclibceabihf --all-targets on my machine. Could the builder's idea of nightly be out of date? Mine builds with:

rustc 1.62.0-nightly (77652b9ef 2022-05-06)

@rtzoeller
Copy link
Collaborator

It seems like it's a day or two behind right now. I'll try again later this weekend.

Thanks again!

@skrap
Copy link
Contributor

skrap commented May 11, 2022

bors try

@bors
Copy link
Contributor

bors bot commented May 11, 2022

🔒 Permission denied

Existing reviewers: click here to make skrap a reviewer

@skrap
Copy link
Contributor

skrap commented May 11, 2022

aw nuts :\

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request May 11, 2022
@bors
Try #1699:
e28d5f9
@bors
Copy link
Contributor

bors bot commented May 11, 2022

try

Build succeeded:

@rtzoeller
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented May 11, 2022

Build succeeded:

@bors bors bot merged commit 6f57f2e into nix-rust:master May 11, 2022
@rtzoeller rtzoeller mentioned this pull request May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomers @rtzoeller @skrap