Expose copy_file_range on FreeBSD and use I/O Safety #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
copy_file_range
branch
4 times, most recently
from
66a79a1
to
fbf6470
Compare
|
@rtzoeller suddenly I'm getting a bunch of errors on musl, android, and qemu. But I can't figure out why they didn't happen before this PR. Any guesses?
Even before this PR, copy_file_range should've been enabled for all of those targets. |
|
Oh, I see. The old version used |
asomers
force-pushed
the
copy_file_range
branch
from
fbf6470
to
497bd4b
Compare
asomers
force-pushed
the
copy_file_range
branch
2 times, most recently
from
63fa5ae
to
9a59112
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
asomers
force-pushed
the
copy_file_range
branch
from
9a59112
to
fa8983e
Compare
And expose it on FreeBSD
asomers
force-pushed
the
copy_file_range
branch
from
fa8983e
to
5d55d8f
Compare
rkuris
referenced
this pull request
in ava-labs/firewood
Aug 28, 2023
Two major changes: - features must be included; we only need two (this will speed up compiles!) - FD safety; we now need an OwnedFd, so attempting to use the fd after the object is dropped is no longer valid. Additionally, we don't need to implement Drop, as OwnedFd already has a drop which calls close References: * [https://github.com/nix-rust/nix/pull/2091](nix PR for features drop) * [https://doc.rust-lang.org/stable/src/std/os/fd/owned.rs.html#170-182](OwnedFd docs) * [https://github.com/nix-rust/nix/pull/1906](nix PR for FD I/O safety)
rkuris
added a commit
to ava-labs/firewood
that referenced
this pull request
Aug 28, 2023
Two major changes: - features must be included; we only need two (this will speed up compiles!) - FD safety; we now need an OwnedFd, so attempting to use the fd after the object is dropped is no longer valid. Additionally, we don't need to implement Drop, as OwnedFd already has a drop which calls close References: * nix-rust/nix#2091 - nix PR for features drop * https://doc.rust-lang.org/stable/src/std/os/fd/owned.rs.html#170-182 - OwnedFd docs * nix-rust/nix#1906 - nix PR for FD I/O safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1862