-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sigset conveniance #1959
Sigset conveniance #1959
Conversation
e13809b
to
da26900
Compare
Seems worthwhile to add a changelog note about this. Otherwise looks good, thanks! |
0da535c
to
263cb45
Compare
@rtzoeller Added change logs notes. |
263cb45
to
a4d0202
Compare
@rtzoeller Could you please re-review. |
b4443d9
to
3a45608
Compare
@@ -9,6 +9,23 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
- Fix `SigSet` incorrect implementation of `Eq`, `PartialEq` and `Hash` | |||
([#1946](https://github.com/nix-rust/nix/pull/1946)) | |||
|
|||
### Added | |||
|
|||
- Added `impl From<Signal> for SigSet`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what happened here, but this sure is a riotous merge error. Could you fix it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Addded
has already been added:
### Added
- Added `impl From<Signal> for SigSet`.
([#1959](https://github.com/nix-rust/nix/pull/1959))
- ...
### Changed
- ...
### Added
- Added `Icmp` and `IcmpV6` to `SockProtocol`.
(#[2103](https://github.com/nix-rust/nix/pull/2103))
There are now two ### Added
sections in this file, we need to merge them
3a45608
to
90aa125
Compare
90aa125
to
bf3ae3d
Compare
@@ -9,6 +9,23 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
- Fix `SigSet` incorrect implementation of `Eq`, `PartialEq` and `Hash` | |||
([#1946](https://github.com/nix-rust/nix/pull/1946)) | |||
|
|||
### Added | |||
|
|||
- Added `impl From<Signal> for SigSet`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Addded
has already been added:
### Added
- Added `impl From<Signal> for SigSet`.
([#1959](https://github.com/nix-rust/nix/pull/1959))
- ...
### Changed
- ...
### Added
- Added `Icmp` and `IcmpV6` to `SockProtocol`.
(#[2103](https://github.com/nix-rust/nix/pull/2103))
There are now two ### Added
sections in this file, we need to merge them
Except for that duplicate CHANGELOG section, this PR LGTM BTW, nice improvement! |
Yeah but I didn't add the 2nd one, there where 2 |
Get it, would you like to fix them in this PR? Merging them as-is still LGTM, then I will fix it in another PR The current |
I think it would make sense to fix this in a specific PR. |
Thanks! |
Adds convenience functions for dealing with
SigSet
.becomes
becomes