Make clone unsafe
#1993
Merged
Make clone unsafe
#1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkoloski
force-pushed
the
unsafe_sched_clone
branch
from
7213504 to
01035ee
Compare
asomers
requested changes
Feb 9, 2023
There was a problem hiding this comment.
Um yes, clone is nearly impossible to use safely. I see that the clone binding has been present in Nix since its very first commit in 2014, back before Rust 1.0. I'm guessing that almost no one has used it since then, which is why nobody has made it unsafe yet. There's only one problem with this PR: could you add a CHANGELOG entry?
djkoloski
force-pushed
the
unsafe_sched_clone
branch
from
01035ee to
60c4a1d
Compare
|
Sorry for the delay, should be good to go now. |
There are many features of `clone` that may cause memory unsafety when called. This documents one of them and references `fork()`, which is already unsafe to call.
asomers
force-pushed
the
unsafe_sched_clone
branch
from
ddafa89 to
eace807
Compare
|
Sorry I missed this PR when last you updated it. I've just hijacked it to fix the merge conflict. |
asomers
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many features of
clonethat may cause memory unsafety when called. This documents one of them and referencesfork(), which is already unsafe to call.Fixes #1975