Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused mut from two variable declarations in sys/socket/mod.rs #2033

Merged
merged 1 commit into from
May 9, 2023
Merged

remove unused mut from two variable declarations in sys/socket/mod.rs #2033

merged 1 commit into from
May 9, 2023

Conversation

inglorion
Copy link
Contributor

This addresses diagnostics like:

error: variable does not need to be mutable
--> src/sys/socket/mod.rs:1537:13
|
1537 | let mut p = &mut mmsghdr.msg_hdr;

@inglorion
remove unused mut from two variable declarations in sys/socket/mod.rs
918a5ab 
This addresses diagnostics like:

  error: variable does not need to be mutable
      --> src/sys/socket/mod.rs:1537:13
       |
  1537 |         let mut p = &mut mmsghdr.msg_hdr;
@inglorion inglorion mentioned this pull request May 9, 2023
Open
asomers
asomers approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume that this is a new warning in the latest nightly compiler.

bors r+

@bors
Copy link
Contributor

bors bot commented May 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit b13b7d1 into nix-rust:master May 9, 2023
@inglorion inglorion deleted the syssock branch May 9, 2023 20:17
asomers pushed a commit to asomers/nix that referenced this pull request Aug 27, 2023
@bors @inglorion @asomers
Merge nix-rust#2033
e867595 
2033: remove unused mut from two variable declarations in sys/socket/mod.rs r=asomers a=inglorion

This addresses diagnostics like:

  error: variable does not need to be mutable
      --> src/sys/socket/mod.rs:1537:13
       |
  1537 |         let mut p = &mut mmsghdr.msg_hdr;

Co-authored-by: Bob Haarman <inglorion@google.com>
asomers pushed a commit to asomers/nix that referenced this pull request Aug 27, 2023
@bors @inglorion @asomers
Merge nix-rust#2033
bdc0e04 
2033: remove unused mut from two variable declarations in sys/socket/mod.rs r=asomers a=inglorion

This addresses diagnostics like:

  error: variable does not need to be mutable
      --> src/sys/socket/mod.rs:1537:13
       |
  1537 |         let mut p = &mut mmsghdr.msg_hdr;

Co-authored-by: Bob Haarman <inglorion@google.com>
asomers pushed a commit to asomers/nix that referenced this pull request Aug 27, 2023
@bors @inglorion @asomers
Merge nix-rust#2033
df3c7a6 
2033: remove unused mut from two variable declarations in sys/socket/mod.rs r=asomers a=inglorion

This addresses diagnostics like:

  error: variable does not need to be mutable
      --> src/sys/socket/mod.rs:1537:13
       |
  1537 |         let mut p = &mut mmsghdr.msg_hdr;

Co-authored-by: Bob Haarman <inglorion@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inglorion @asomers