Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduces FreeBSD's SO_TS_CLOCK into net::sys::socket::sockopt. #2093

Merged
merged 3 commits into from
Aug 27, 2023
Merged

introduces FreeBSD's SO_TS_CLOCK into net::sys::socket::sockopt. #2093

merged 3 commits into from
Aug 27, 2023

Conversation

devnexen
Copy link
Contributor

close GH-2058.

asomers
asomers reviewed Aug 26, 2023
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it needs a rebase to fix a merge conflict in CHANGELOG. Also, you should probably change it to Both instead of SetOnly. It works both ways.

@asomers
Copy link
Member

asomers commented Aug 26, 2023

Guess what? It needs another rebase, both to fix the CHANGELOG and to fix CI.

@asomers asomers added this pull request to the merge queue Aug 26, 2023
Merged via the queue into nix-rust:master with commit 93d43a7 Aug 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SO_TS_CLOCK sockopt for packet timestamping on FreeBSD.
2 participants
@devnexen @asomers