-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise MSRV to 1.69.0 #2144
Raise MSRV to 1.69.0 #2144
Conversation
let nul = buf.iter().position(|c| *c == b'\0').unwrap(); | ||
buf.truncate(nul); | ||
Ok(OsString::from_vec(buf).into()) | ||
CStr::from_bytes_until_nul(&buf[..]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [..]
in &buf[..]
seems to be unnecessary here
The MSRV in
BTW, it seems that the version of the next release would be |
We would have to do that anyway, since we've changed the signatures of several functions to add I/O safety. |
The CI failure of
seems to be because that the alias
|
To fix the CI failure in
// old one
use std::ffi::{CStr, OsString};
#[cfg(not(target_os = "redox"))]
use std::ffi::{CString, OsStr}; // new one, the CI failure should be resolved by this
use std::ffi::{CStr, OsStr, OsString};
#[cfg(not(target_os = "redox"))]
use std::ffi::CString; |
This allows us to use the very useful CStr::from_bytes_until_nul
x86_64-fuchsia -> x86_64-unknown-fuchsia
This allows us to use the very useful CStr::from_bytes_until_nul